Skip to content

DEP/DEPR: bump minimal requirement on matplotlib from 3.6 to 3.7 and deprecate yt.funcs.matplolib_style_context #5362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
neutrinoceros wants to merge 2 commits into
base: main
Choose a base branch
from
Open

DEP/DEPR: bump minimal requirement on matplotlib from 3.6 to 3.7 and deprecate yt.funcs.matplolib_style_context #5362

neutrinoceros wants to merge 2 commits into from

Conversation

@neutrinoceros
Copy link
Member

@neutrinoceros neutrinoceros commented Jan 7, 2026

PR Summary

I've been planning this for a while. matplotlib 3.7 is now almost 3 years old so I think this bump should be uncontroversial ?

PR Checklist

  • New features are documented, with docstrings and narrative docs
  • Adds a test for any bugs fixed. Adds tests for new features.

@neutrinoceros neutrinoceros added this to the 4.5.0 milestone Jan 7, 2026
@neutrinoceros neutrinoceros added viz: 2D dependencies Pull requests that update a dependency file deprecation deprecate features or remove deprecated ones labels Jan 7, 2026
@neutrinoceros neutrinoceros force-pushed the dep/bump-matplotlib-3.7 branch from f9f316b to e03db64 Compare January 7, 2026 11:07
@neutrinoceros neutrinoceros marked this pull request as ready for review January 7, 2026 11:11
@neutrinoceros neutrinoceros added the dead code removing internal bits that have no effect label Jan 7, 2026
@neutrinoceros neutrinoceros changed the title DEP/DEPR: bump minimal requirement on matplotlib from 3.6 to 3.7 and deprecate yt.func.matplolib_style_context DEP/DEPR: bump minimal requirement on matplotlib from 3.6 to 3.7 and deprecate yt.funcs.matplolib_style_context Jan 7, 2026
@neutrinoceros neutrinoceros force-pushed the dep/bump-matplotlib-3.7 branch 2 times, most recently from aa5d3a4 to 6e2f5d2 Compare January 7, 2026 17:26
@neutrinoceros neutrinoceros force-pushed the dep/bump-matplotlib-3.7 branch from 6e2f5d2 to 8aac693 Compare January 7, 2026 18:39
chrishavlin
chrishavlin previously approved these changes Jan 13, 2026
View reviewed changes
Copy link
Contributor

@chrishavlin chrishavlin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bumping to mpl 3.7 seems reasonable to me (and all the changes here LGTM)

@neutrinoceros @chrishavlin
Update plots.rst
fb4a514 
Co-authored-by: Chris Havlin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrishavlin chrishavlin chrishavlin approved these changes

Assignees

No one assigned

Labels

dead code removing internal bits that have no effect dependencies Pull requests that update a dependency file deprecation deprecate features or remove deprecated ones viz: 2D

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@neutrinoceros @chrishavlin