Skip to content

Conversation

@chrishavlin
Copy link
Contributor

@chrishavlin chrishavlin commented Sep 29, 2025

This PR:

  • refactors the block collection to create an abstract base class for collections
  • adds a GridCollection object for directly rendering a list of covering or arbitrary grid objects

Close #217

To do:

  • add some figures to this PR
  • update docs
  • get the block outlines working for GridCollection

example outputs

Here are the outputs of the test with a list of arbitrary covering grid.

for cartesian coords:

grid_collection_cart_01

for spherical coords:

grid_collection_sphere_01

And the output of examples/grid_collections_enzo_64.py, which loads 2 covering grids:

snap_0000

@chrishavlin chrishavlin added the enhancement New feature or request label Sep 29, 2025
@chrishavlin chrishavlin marked this pull request as draft September 29, 2025 19:25
@chrishavlin
Copy link
Contributor Author

the cartesian covering grid test image is empty

@chrishavlin
Copy link
Contributor Author

grid outlines working -- also removed the block outlines menu item for this rendering object since they are not applicable.

snap_0000

@chrishavlin chrishavlin marked this pull request as ready for review September 29, 2025 20:56
@chrishavlin
Copy link
Contributor Author

oh, hit undraft too soon maybe. forgot i need to double check the plain covering_grid behavior

@chrishavlin chrishavlin marked this pull request as draft October 7, 2025 18:42
@chrishavlin chrishavlin added this to the 0.6.0 milestone Oct 7, 2025
@chrishavlin chrishavlin marked this pull request as ready for review October 7, 2025 20:04
@chrishavlin
Copy link
Contributor Author

well, very confused about why the cartesian covering grid test case saves an empty image... running the same code locally with osmesa returns the expected figure

grid_coll_offscreen_cartesian_covering

it's only when running it in pytest that it is empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ENH: block collection subclass to directly load a list of grids?

1 participant