-
Notifications
You must be signed in to change notification settings - Fork 5
preprocessor directives followup #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preprocessor directives followup #89
Conversation
|
draft for now (but feel free to look now, @matthewturk ). I went through a couple iterations of approaches, want to double check that I didn't leave behind unwanted code... but also wanted to push this up now :) |
|
oh, also a draft cause I didn't actually run the tests locally. oops. so will have to fix a few things. but right now: running |
ae46023 to
6e3e08d
Compare
|
oops, bad merge... |
|
Thing this needs much else? |
nope! just added some tests. |
matthewturk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this. I think it would also be helpful for the compute shaders stuff in #143, because we could use it to set the workgroup size. Nice!
|
ya! lots of potential uses! |
This PR follows on #70 and
use_db) with a preprocessorUSE_DBdefinition. I'm actually not sure switching this to a pre-processor directive is better or worse, but it does nicely illustrate the functionality.