Skip to content

Conversation

@akshatmardia
Copy link

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.

Working on refactoring the code according to the TODO comments found:

Image

TODO found in /youtube_dl/traversal.py which says TODO: move these utils.fns here and move import to utils.

I have moved the functions and added the imports in /youtube_dl/utils.py but flake8 does not like that they are not all being used in utils.py but being imported in other files via utils.py. Note that the tests pass for both utils.py and traversal.py.

Should I add traversal.py imports in those separate files or just ignore the flake8 error and let them be imported from utils.py?

Image

This PR ignores the flake8 error with #noqa

@akshatmardia akshatmardia changed the title [Refactor] Moved utils fns to traversal.py Refactor (moved utils fns to traversal.py) Mar 28, 2025
@akshatmardia
Copy link
Author

@dirkf can I get a review please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant