Refactor (moved utils fns to traversal.py) #33099
Open
+489
−477
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.
Working on refactoring the code according to the TODO comments found:
TODO found in
/youtube_dl/traversal.pywhich saysTODO: move these utils.fns here and move import to utils.I have moved the functions and added the imports in
/youtube_dl/utils.pybut flake8 does not like that they are not all being used inutils.pybut being imported in other files viautils.py. Note that the tests pass for bothutils.pyandtraversal.py.Should I add
traversal.pyimports in those separate files or just ignore the flake8 error and let them be imported fromutils.py?This PR ignores the flake8 error with
#noqa