Add schema_name as an attribute to table metrics #29121
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change propagates PostgreSQL schema names from the PgGate layer through the Master to Tablets, and exposes them as a metric attribute for YSQL tables. This enables filtering and aggregation of table-related metrics by schema name, allowing distinction between tables with the same name in different schemas within the same database. Changes: - Add schema_name field to TableInfoPB and SysTablesEntryPB protobufs - Extract schema_name from DEPRECATED_pgschema_name in Master's CreateTable - Propagate schema_name through CreateTabletRequestPB to tablet servers - Add schema_name to TableInfo struct and all copy constructors - Expose schema_name as a metric attribute in Tablet::Init for YSQL tables - Maintain backward compatibility with empty schema_name default 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
|
✅ Deploy Preview for infallible-bardeen-164bc9 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #28866
This change propagates PostgreSQL schema names from the PgGate layer through the Master to Tablets, and exposes them as a metric attribute for YSQL tables. This enables filtering and aggregation of table-related metrics by schema name, allowing distinction between tables with the same name in different schemas within the same database.
Changes:
🤖 Generated with Claude Code