Skip to content

DocDB: Reduce spammy logs in cdc service, tx manager, and rocksdb operations #29350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DocDB: Reduce spammy logs in cdc service, tx manager, and rocksdb operations #29350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/yb/cdc/cdc_service.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2947,7 +2947,7 @@ Result<TabletCDCCheckpointInfo> CDCServiceImpl::PopulateCDCSDKTabletCheckPointIn

auto get_stream_metadata = GetStream(stream_id, RefreshStreamMapOption::kIfInitiatedState);
if (!get_stream_metadata.ok()) {
LOG(WARNING) << "Read invalid stream id: " << stream_id << " for tablet " << tablet_id << ": "
Copy link
Contributor

@hari90 hari90 Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should NOT be seeing too many of this one

Copy link
Author

@austenLacy austenLacy Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the past hour, we've seen this log 1.7M times. This is a factor of the number of tablets of which we have around 21k currently. Not all of those tablets are being CDC'd but many thousands are.

Do you have recommendations for what we should look into since we are seeing this log as frequently as we do?

VLOG_WITH_FUNC(2) << "Read invalid stream id: " << stream_id << " for tablet " << tablet_id << ": "
<< get_stream_metadata.status();
break;
}
Expand Down Expand Up @@ -4713,8 +4713,7 @@ void CDCServiceImpl::RemoveXReplTabletMetrics(
}
auto tablet = tablet_peer->shared_tablet_maybe_null();
if (tablet == nullptr) {
YB_LOG_EVERY_N_SECS_OR_VLOG(WARNING, 300, 4)
<< "Could not find tablet for tablet peer: " << tablet_peer->tablet_id();
VLOG_WITH_FUNC(2) << "Could not find tablet for tablet peer: " << tablet_peer->tablet_id();
return;
}

Expand Down
2 changes: 1 addition & 1 deletion src/yb/client/transaction_manager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ class TransactionTableState {
if (PickStatusTabletId(tablets, callback)) {
return;
}
YB_LOG_EVERY_N_SECS(WARNING, 1) << "No local transaction status tablet found";
YB_LOG_EVERY_N_SECS(WARNING, 10) << "No local transaction status tablet found";
Copy link
Contributor

@hari90 hari90 Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting to 10s is fine. But if you see this then it means you dont have enough transaction status tablets and should take action to create more soon .

Copy link
Author

@austenLacy austenLacy Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of our transaction status tables are between 200-450 tablets. What's the scaling factor we should consider for these tablets?

callback(RandomElement(tablets));
}

Expand Down
2 changes: 1 addition & 1 deletion src/yb/master/xrepl_catalog_manager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3004,7 +3004,7 @@ Status CatalogManager::CleanupXReplStreamFromMaps(CDCStreamInfoPtr stream) {

Status CatalogManager::GetCDCStream(
const GetCDCStreamRequestPB* req, GetCDCStreamResponsePB* resp, rpc::RpcContext* rpc) {
LOG(INFO) << "GetCDCStream from " << RequestorString(rpc) << ": " << req->DebugString();
VLOG(2) << "GetCDCStream from " << RequestorString(rpc) << ": " << req->DebugString();

if (!req->has_stream_id() && !req->has_cdcsdk_ysql_replication_slot_name()) {
return STATUS(
Expand Down
2 changes: 1 addition & 1 deletion src/yb/rocksdb/db/db_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2150,7 +2150,7 @@ Result<FileNumbersHolder> DBImpl::FlushMemTableToOutputFile(
*made_progress = 1;
}
VersionStorageInfo::LevelSummaryStorage tmp;
YB_LOG_EVERY_N_SECS(INFO, 1)
YB_LOG_EVERY_N_SECS(INFO, 10)
<< "[" << cfd->GetName() << "] Level summary: "
<< cfd->current()->storage_info()->LevelSummary(&tmp);
}
Expand Down
2 changes: 1 addition & 1 deletion src/yb/rpc/reactor.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,7 @@ void Reactor::ScanIdleConnections() {
if (connection_delta > connection_keepalive_time_) {
conn->Shutdown(STATUS_FORMAT(
NetworkError, "Connection timed out after $0", ToSeconds(connection_delta)));
LOG_WITH_PREFIX(INFO)
VLOG(2)
<< "DEBUG: Closing idle connection: " << conn->ToString()
<< " - it has been idle for " << ToSeconds(connection_delta) << "s";
VLOG(1) << "(delta: " << ToSeconds(connection_delta)
Expand Down
Loading