Skip to content

yugabyted: stop child processes with SIGTERM instead of SIGKILL #29676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rylan12 wants to merge 3 commits into
base: master
Choose a base branch
from
+10 −6
Open

yugabyted: stop child processes with SIGTERM instead of SIGKILL #29676

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3fa7e40
`yugabyted`: stop child processes with `SIGTERM` instead of `SIGKILL`
Rylan12 Dec 11, 2025
70dd64f
Use `SIGKILL` only after `SIGTERM`
Rylan12 Jan 9, 2026
0da7f69
Wait for processes to stop after terminating
Rylan12 Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions bin/yugabyted
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3191,14 +3191,18 @@ class ControlScript(object):
os._exit(os.EX_OK)
self.set_signals(SIG_DFL)

for p in self.processes.values():
p.delete_pidfile()
self.script.delete_pidfile()

try:
for p in self.processes.values():
p.kill()

for p in self.processes.values():
p.wait_until_stop()

self.script.delete_pidfile()

# Kill process group instead of self.processes to ensure
# any spawned child processes are killed. Use SIGKILL because YugaWare
# requires KILL signal to terminate and nodes currently do not gracefully terminate.
# any spawned child processes are killed.
# This will terminate any processes that didn't respond to SIGTERM.
os.killpg(pgid, SIGKILL)
Output.log(
"{} may not have terminated properly... "
Expand Down