[#31519] Tests: Fix PgAshNestedQueryTracking on macOS by raising kNumRows#31520
Open
ellabaron-code wants to merge 1 commit into
Open
[#31519] Tests: Fix PgAshNestedQueryTracking on macOS by raising kNumRows#31520ellabaron-code wants to merge 1 commit into
ellabaron-code wants to merge 1 commit into
Conversation
Bump kNumRows from 1000 to 10000 so the inner query is on a backend long enough to be sampled by ASH (kSamplingIntervalMs = 50ms). On fast hardware (macOS arm64), 1000 trigger firings of the inner query complete inside a single sample tick, so the sampler never catches it active and InnerAshQpmMatch() returns 0.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
✅ Deploy Preview for infallible-bardeen-164bc9 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
trigger jenkins |
Contributor
|
Jenkins build has been triggered. Results will be posted once it completes. CSI JenkinsBot |
GauravSingh-yb
approved these changes
May 8, 2026
GauravSingh-yb
left a comment
GauravSingh-yb
left a comment
There was a problem hiding this comment.
LGTM!
Yes, the test may become flaky on faster machines.
Contributor
|
✅ Jenkins build for commit Passed: 9 🔨 DB Build/Test Job Summary
JenkinsBot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
kNumRowsfrom 1000 to 10000 inPgAshNestedQueryTrackingso theinner trigger query stays active long enough to be sampled by ASH
(
kSamplingIntervalMs = 50ms). On fast hardware (macOS arm64), 1000trigger firings of the inner query complete inside a single sample
tick, so the sampler never catches it active and
InnerAshQpmMatch()returns 0.
Fixes #31519.
Test plan
./yb_build.sh release --cxx-test pg_ash-test --gtest_filter PgAshTest.PgAshNestedQueryTrackingpasses.kNumRowsonly makes the inner query window larger, not smaller).CSI