Skip to content

[DOC-1360][2025.2.4] Document ALTER ROLE/ALTER DATABASE handling in YSQL Connection Manager#32138

Open
arpit-saxena wants to merge 6 commits into
yugabyte:masterfrom
arpit-saxena:alter_docs
Open

[DOC-1360][2025.2.4] Document ALTER ROLE/ALTER DATABASE handling in YSQL Connection Manager#32138
arpit-saxena wants to merge 6 commits into
yugabyte:masterfrom
arpit-saxena:alter_docs

Conversation

@arpit-saxena

Copy link
Copy Markdown
Member

This doc change documents how ALTER ROLE SET and ALTER DATABASE SET commands are handled by YSQL Connection Manager, including the new ysql_conn_mgr_alter_guc_adoption_strategy and ysql_conn_mgr_alter_guc_stale_backend_ttl_ms flags.

arpit-saxena and others added 4 commits June 11, 2026 19:21
The section heading was renamed to 'ALTER ROLE SET / ALTER DATABASE SET
commands', so update the two in-page links to use the matching
blackfriday anchor and link text.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@arpit-saxena arpit-saxena requested a review from aishwarya24 June 11, 2026 14:09
@arpit-saxena arpit-saxena added the area/documentation Documentation needed label Jun 11, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the YSQL Connection Manager documentation to introduce two new configuration flags, ysql_conn_mgr_alter_guc_adoption_strategy and ysql_conn_mgr_alter_guc_stale_backend_ttl_ms, which manage how GUC settings changed by ALTER ROLE/DATABASE statements are adopted. It also documents a known limitation regarding the propagation of these changes across multiple nodes. The review feedback suggests replacing the slash in the new markdown header with 'and' to ensure consistent anchor generation and prevent broken links across different markdown renderers.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

- Any string-type variables of extensions
- `yb_read_after_commit_visibility`

## ALTER ROLE SET / ALTER DATABASE SET commands

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using a slash (/) in markdown headers can lead to inconsistent anchor generation across different markdown renderers (such as GitHub vs. Hugo/Goldmark), which can break relative links. Consider replacing the slash with and to ensure consistent and robust anchor generation. If you apply this change, please also update the corresponding links on lines 127 and 264 to use #alter-role-and-alter-database-set-commands.

Suggested change
## ALTER ROLE SET / ALTER DATABASE SET commands
## ALTER ROLE and ALTER DATABASE SET commands

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in e48585e. Replaced the slash with and in the header and updated both cross-references (lines 127 and 264) to the new anchor #alter-role-set-and-alter-database-set-commands. Note the header has SET in both halves, so the anchor includes it.


automated · Claude Code (Opus 4.8)

@netlify

netlify Bot commented Jun 11, 2026

Copy link
Copy Markdown

Deploy Preview for infallible-bardeen-164bc9 ready!

Name Link
🔨 Latest commit 324eb6d
🔍 Latest deploy log https://app.netlify.com/projects/infallible-bardeen-164bc9/deploys/6a2b3cf3e8253400087566ee
😎 Deploy Preview https://deploy-preview-32138--infallible-bardeen-164bc9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Slashes in markdown headers can produce inconsistent anchors across
renderers (GitHub vs. Hugo/Goldmark). Update the header and the two
cross-references to use the slash-free anchor.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@aishwarya24 aishwarya24 requested a review from ddhodge June 11, 2026 17:17

@ddhodge ddhodge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/documentation Documentation needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants