[DOC-1361][2025.2.4][2026.1] Add flags for CM ctrl conn creds and socket backlog size#32144
[DOC-1361][2025.2.4][2026.1] Add flags for CM ctrl conn creds and socket backlog size#32144vdamle-yb wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds documentation for three new YSQL Connection Manager flags: ysql_conn_mgr_internal_conn_db, ysql_conn_mgr_internal_conn_user, and ysql_conn_mgr_socket_listen_backlog. A review comment notes a discrepancy between the documented flag name ysql_conn_mgr_socket_listen_backlog and the name ysql_conn_mgr_internal_tcp_listen_backlog used in the PR description, which needs to be verified and corrected.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| | ysql_conn_mgr_reserve_internal_conns | The number of physical connections to reserve for internal operations, out of the total number of connections (per node) as set using [ysql_max_connections](../../../reference/configuration/yb-tserver/#ysql-max-connections). The reserved connections bypass YSQL Connection Manager; the remaining connections are available for the Connection Manager pool. For example, if `ysql_max_connections` is 300 and this flag is set to 15, YSQL Connection Manager will have a physical connection limit of 285 (300 - 15) per node.<br>Default: 15. v2025.2.1.0 and later only. | | ||
| | ysql_conn_mgr_internal_conn_db | Database to which YSQL Connection Manager connects when creating internal database connections.<br>Default: yugabyte | | ||
| | ysql_conn_mgr_internal_conn_user | Username used by YSQL Connection Manager when creating internal database connections.<br>Default: yugabyte | | ||
| | ysql_conn_mgr_socket_listen_backlog | Maximum number of pending TCP connections queued by the kernel on Connection Manager's listening socket (the backlog argument to `listen(2)`). Incoming connections beyond this limit may be refused or dropped during connection bursts.<br>Default: 128 | |
There was a problem hiding this comment.
There is a discrepancy between the flag name documented here (ysql_conn_mgr_socket_listen_backlog) and the one listed in the PR description (ysql_conn_mgr_internal_tcp_listen_backlog). Please verify which flag name is correct in the codebase and update the documentation or PR description accordingly.
References
- Anything that contradicts a comment, docstring, or commit message in the same diff should be flagged. (link)
There was a problem hiding this comment.
Updated the PR description
✅ Deploy Preview for infallible-bardeen-164bc9 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for infallible-bardeen-164bc9 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
1 participant
This doc change adds descriptions in ycm-setup.md for the following 3 flags:
ysql_conn_mgr_internal_conn_dbysql_conn_mgr_internal_conn_userysql_conn_mgr_internal_socket_listen_backlogThese flags are present in 2025.2 (release 2025.2.4 onwards) and 2026.1 (2026.1.0 onward) as well.