役職作成ドキュメント（メソッド・インターフェース）の網羅的更新#830
Conversation
Updated `07_interfaces.md` and `08_methods.md` to include missing interfaces and virtual methods from the codebase. Each entry now includes method signatures, detailed argument/return value descriptions, and practical code examples. Additionally, corrected broken or outdated links across the role development documentation. Co-authored-by: yukieiji <40425798+yukieiji@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a comprehensive update to the role creation development documentation. It ensures that all necessary interfaces and methods for role customization are thoroughly documented with clear explanations and code examples, while also cleaning up internal navigation links to maintain a consistent and accurate developer experience. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Roles defined with care and grace, Methods mapped in every place. Docs now clear for all to see, Coding joy for you and me. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reorganizes and expands the developer documentation for role creation, providing more comprehensive details on interfaces and SingleRoleBase methods. Key updates include categorized interface descriptions and expanded lifecycle documentation. Feedback was provided to correct a typo in the HookMurderPlayer method and to clarify the distinction between fields and properties for certain class members.
|
|
||
| #### `IRoleMurderPlayerHook` | ||
| プレイヤーが殺害される瞬間の処理に割り込みます（キルボタン押下時ではなく、実際の死亡処理時）。 | ||
| - `void HookMuderPlayer(PlayerControl source, PlayerControl target)` |
There was a problem hiding this comment.
HookMuderPlayer は HookMurderPlayer のスペルミスと思われます。
| - `void HookMuderPlayer(PlayerControl source, PlayerControl target)` | |
| - void HookMurderPlayer(PlayerControl source, PlayerControl target) |
| ## 実装のポイント | ||
|
|
||
| これらのインターフェースは、Roleクラス自体に実装することも可能ですが、ロジックの肥大化を防ぐために **AbilityHandler に実装し、Roleクラスから呼び出す** か、**Roleクラスが保持する AbilityClass にそのインターフェースを実装したインスタンスを割り当てる** 設計が推奨されます。 | ||
| `SingleRoleBase` は多くの `virtual` プロパティ（`CanUseAdmin`, `UseVent` など）を持っています。これらをコンストラクタや `RoleSpecificInit` で適切に設定することで、役職の基本的な能力を定義できます。 |
There was a problem hiding this comment.
CanUseAdmin や UseVent は SingleRoleBase.cs の実装では virtual プロパティではなくフィールドとして定義されているため、表現を「フィールドやプロパティ」に修正することを推奨します。
| `SingleRoleBase` は多くの `virtual` プロパティ（`CanUseAdmin`, `UseVent` など）を持っています。これらをコンストラクタや `RoleSpecificInit` で適切に設定することで、役職の基本的な能力を定義できます。 | |
| SingleRoleBase は多くのフィールドやプロパティ（CanUseAdmin, UseVent など）を持っています。これらをコンストラクタや RoleSpecificInit で適切に設定することで、役職の基本的な能力を定義できます。 |
GitHub Actions MSBuilds
Translation Checker Report
|
1 participant
役職作成に関する開発ドキュメントを大幅に更新しました。
07_interfaces.md:IRoleWinPlayerModifier,IRoleSpecialSetUp,IRoleAwake,IRoleOnReviveなどの不足していたインターフェースをすべて網羅。08_methods.md:SingleRoleBaseの主要なオーバーライド可能メソッド（RolePlayerKilledAction,GetTargetRoleSeeColor,GetImportantTextなど）をすべて網羅。リンクの修正:
01_overview.md,02_role_class.md,04_ability_handler.md内の古いリンクや間違ったファイル名へのリンクを最新の状態に修正。PR created automatically by Jules for task 4377101141010160149 started by @yukieiji