Fix from_dict for Optional values in collections#733
Merged
yukinarit merged 1 commit intoyukinarit:mainfrom Mar 19, 2026
Merged
Fix from_dict for Optional values in collections#733yukinarit merged 1 commit intoyukinarit:mainfrom
yukinarit merged 1 commit intoyukinarit:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #733 +/- ##
==========================================
- Coverage 90.83% 90.81% -0.02%
==========================================
Files 13 13
Lines 2040 2308 +268
Branches 370 449 +79
==========================================
+ Hits 1853 2096 +243
- Misses 124 141 +17
- Partials 63 71 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following fixes are applied with the help of LLM agent:
DeField.__getitem__to preserveInnerFieldtype when unwrapping Optional inside a collection, so the generated code accesses the loop variable directly instead of indexing into it by nameRenderer.opt()to use a simpleis not Nonecheck forInnerFieldinstead of applying thedatavar.get("fieldname")pattern meant for named dataclass fieldsFixes #732