Skip to content

fix: order by fields must be in group by (compatible for Dameng) #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swordqiu merged 1 commit into from
Mar 7, 2025
Merged

fix: order by fields must be in group by (compatible for Dameng) #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions querydefs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,11 +195,30 @@ func queryString(tq *SQuery, tmpFields ...IQueryField) string {
}
if tq.groupBy != nil && len(tq.groupBy) > 0 {
buf.WriteString(" GROUP BY ")
for i, f := range tq.groupBy {
groupByFields := make(map[string]IQueryField)
for i := range tq.groupBy {
f := tq.groupBy[i]
if _, ok := groupByFields[f.Reference()]; ok {
continue
}
if i > 0 {
buf.WriteString(", ")
}
buf.WriteString(f.Reference())
groupByFields[f.Reference()] = f
}
// DAMENG SQL Compatibility, all order by fields should be in group by
for i := range tq.orderBy {
f := tq.orderBy[i]
if _, ok := groupByFields[f.field.Reference()]; ok {
continue
}
if ff, ok := f.field.(IFunctionQueryField); ok && ff.IsAggregate() {
continue
}
buf.WriteString(", ")
buf.WriteString(f.field.Reference())
groupByFields[f.field.Reference()] = f.field
}
}
/*if tq.having != nil {
Expand All @@ -208,7 +227,8 @@ func queryString(tq *SQuery, tmpFields ...IQueryField) string {
}*/
if tq.orderBy != nil && len(tq.orderBy) > 0 {
buf.WriteString(" ORDER BY ")
for i, f := range tq.orderBy {
for i := range tq.orderBy {
f := tq.orderBy[i]
if i > 0 {
buf.WriteString(", ")
}
Expand Down