Fix deprecation warnings for Python 3.14+ #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…routinefunction `asyncio.iscoroutinefunction` is deprecated since Python 3.14 and slated for removal in Python 3.16. Replace with `inspect.iscoroutinefunction` which is available since Python 3.5 and provides the same functionality. This change maintains backward compatibility with Python 3.9+.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix deprecation warnings for Python 3.14+
This PR replaces the deprecated asyncio.iscoroutinefunction() with inspect.iscoroutinefunction() to ensure Sanic tests run without deprecation warnings on Python 3.14+.
When running Sanic tests with Python 3.14, the following deprecation warnings appear:
DeprecationWarning: 'asyncio.iscoroutinefunction' is deprecated and slated for removal in Python 3.16; use inspect.iscoroutinefunction() instead
The warnings originate from pytest_sanic/plugin.py at lines 124 and 238.
Replace asyncio.iscoroutinefunction() with inspect.iscoroutinefunction() in both locations. The inspect module is already imported, so no additional dependencies are needed.