Fix macOS CI broken due to disabled llvm@12, bump Ubuntu to 24 #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutotakano
force-pushed
the
try-fix-llvm-12
branch
from
972b797 to
2e93269
Compare
yutotakano
changed the title
Owner
Author
|
This PR introduces an issue where on GHC 8.10.7, the cabal resolver finds a local maxima that doesn't involve the newest supported discord-haskell version (1.17.1) and instead choose 1.13.0. This is because the version restrictions on 1.17.1 lead to more negative scoring of the solver solution compared to 1.13.0 which has no version restrictions on dependencies. The issue will be fixed when #59 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the macOS 8.10.7 CI being broken because of 8.10.7 requiring llvm < 13 when Homebrew have disabled llvm@12 since the first of July this year. The solution is to override the disabled status in a local copy of the formula, then install from that (hinting to Homebrew that it should prioritise local copies over the Homebrew web API).
Ubuntu 20.04 was also phased out this May, so this PR also bumps the standard Ubuntu cases to run on 24.04. In addition, GHC versions up to Stackage LTS (9.8.4) was added for the standard Ubuntu CI matrix. Once #59 is merged, we can also add 9.10 and 9.12 in the CI at least for the standard Ubuntu matrix.
For Windows and Mac CI (which are supplementary to the ubuntu matrix which tests all supported GHC versions), this PR also adds LTS compilation tests because only running 8.10.7 felt a little outdated.