feat: make TensorRT export script configurable #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the TensorRT engine export script configurable by adding CLI arguments for the output path (--trt-path), ONNX model path (--onnx-path), and precision (--use-fp16). These changes improve usability for DepthAnything engines.
rickstaa
force-pushed
the
feature/add-export-trt-args
branch
from
ee7f75d to
1eb458d
Compare
|
Thanks! |
rickstaa
added a commit
to yondonfu/comfystream
that referenced
this pull request
May 20, 2025
We previously used a fork of https://github.com/yuvraj108c/ComfyUI-Depth-Anything-Tensorrt because the original script lacked support for parameters needed to create multiple TensorRT engines. Now that yuvraj108c/ComfyUI-Depth-Anything-Tensorrt#14 has been merged upstream, this workaround is no longer necessary. We can safely return to the main repository.
eliteprox
pushed a commit
to livepeer/comfystream
that referenced
this pull request
May 20, 2025
Now that yuvraj108c/ComfyUI-Depth-Anything-Tensorrt#14 has been merged upstream, this workaround is no longer necessary. We can safely return to the main repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the TensorRT engine export script configurable by adding CLI arguments for the output path (--trt-path), ONNX model path (--onnx-path), and precision (--use-fp16). These changes improve usability for DepthAnything
engines.