Add ext as possible option with --otherdir - #18
Draft
Brisppy wants to merge 3 commits into
Draft
Conversation
Brisppy
marked this pull request as draft
December 7, 2023 01:01
…rdering giving an invalid match
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the use of
{ext}with--otherdir. This is done by grabbing the extension from the last track inside the album directory and using its' metadata as albums can only be downloaded in one format (as far as I'm aware). Not sure if there's a better way of doing this but I'm open to anything.Also wanted to bring something else up with
--output. By default if using just--outputyou end up with a spam of extra folders containing just album covers (due to the--otherdirdefault). I think it would be nice to clean these up automatically, potentially by removing the extra files if--outputis provided but not--otherdir, or try and create a--otherdirbased on the provided--outputformat.Again thanks for making this project!