✨ zb: Add gvariant feature #1398
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
As I wrong on Matrix, this will be a last resort and sounds like a workaround. So we should file an issue on Cargo about this and include a FIXME note here pointing to that issue. |
Allows enabling the gvariant features in the sub-crates without adding them explicitly. Fixes: z-galaxy#1125
A6GibKm
force-pushed
the
add-gvariant-feature
branch
from
1d3d413 to
621b623
Compare
Contributor
|
There is a possible problem with this, which is why I had removed this feature from zbus. See the log of c49e085. |
Contributor
|
Converted to draft to avoid accidental merge. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows enabling the gvariant features in the sub-crates without adding them explicitly.
This can be seen working at bilelmoussaoui/oo7#262.
Fixes (for real): #1125