✨ zb: Add helper for IBus connection creation #1697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeenix
reviewed
Jan 24, 2026
Contributor
zeenix
left a comment
zeenix
left a comment
There was a problem hiding this comment.
Didn't look very thoroughly yet but looks good to me in general.
cachebag
force-pushed
the
main
branch
2 times, most recently
from
d7320e5 to
591cb02
Compare
zeenix
requested changes
Jan 26, 2026
Make the run() function and output() method available on all Unix platforms instead of just macOS, as other Unix systems may need to execute commands.
cachebag
force-pushed
the
main
branch
5 times, most recently
from
24609ac to
5779192
Compare
zeenix
requested changes
Jan 27, 2026
Contributor
zeenix
left a comment
zeenix
left a comment
There was a problem hiding this comment.
LGTM otherwise. Thanks for going the extra mile on this. :) BTW, one of your commit messages is breaking lines too early. 50 chars suggestion is only for the title/shortlog. :)
cachebag
force-pushed
the
main
branch
2 times, most recently
from
7f0176e to
e015237
Compare
cachebag
force-pushed
the
main
branch
3 times, most recently
from
dc3299f to
bc95948
Compare
Contributor
Not yet addressed btw. :) |
zeenix
requested changes
Jan 28, 2026
cachebag
force-pushed
the
main
branch
2 times, most recently
from
51563e0 to
c925cf4
Compare
Add async-recursion dependency for Unix platforms to support async recursion in transport connection methods.
cachebag
force-pushed
the
main
branch
2 times, most recently
from
18fd021 to
bf0c752
Compare
Implement connection::Builder::ibus() for connecting with IBus. The IBus address is fetched from the ibus address command, handled similarly to how we handle the launchd address on macOS. Fixes z-galaxy#964
zeenix
reviewed
Jan 30, 2026
Contributor
zeenix
left a comment
zeenix
left a comment
There was a problem hiding this comment.
Looks great now! One tiny thing.
cachebag
force-pushed
the
main
branch
2 times, most recently
from
76e89cc to
94d1b6e
Compare
zeenix
approved these changes
Jan 31, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
connection::Builder::ibus()for connecting with IBus. The IBus address is fetched from theibus addresscommand, and is handled similarly to how we handle thelaunchdaddress on macOS.Fixes #964