Skip to content

Feature/fix sourcemap url #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
z0ffy merged 2 commits into from
Dec 8, 2025
Merged

Feature/fix sourcemap url #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9683f5
refactor: enhance source map handling and file name resolution
z0ffy Dec 8, 2025
5a183db
docs: update README logo URL to point to new path
z0ffy Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div align="center">

<img height="160" src="https://obfuscator.io/images/logo.png" alt="vite-plugin-bundle-obfuscator logo" />
<img height="160" src="https://obfuscator.io/logo.png" alt="vite-plugin-bundle-obfuscator logo" />

# vite-plugin-bundle-obfuscator

Expand Down
3 changes: 3 additions & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,13 @@ export default function viteBundleObfuscator(config?: Partial<Config>): PluginOp
const configResolvedHandler: (resolvedConfig: ResolvedConfig) => void | Promise<void> = (resolvedConfig) => {
const sourcemap = resolvedConfig.build.sourcemap;
if (sourcemap) {
const output = resolvedConfig.build.rollupOptions?.output;
const sourcemapBaseUrl = !isArray(output) ? output?.sourcemapBaseUrl : undefined;
Comment on lines +111 to +112

@sourcery-ai sourcery-ai Bot Dec 8, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: sourcemapBaseUrl is ignored when rollupOptions.output is an array, which might be surprising for multi-output builds.

Because of the !isArray(output) guard, sourcemapBaseUrl is effectively unsupported for multi-output Rollup configs, even when all outputs could share the same base URL. If multi-output builds are a target use case, consider either handling the array case (e.g., ensure all outputs have the same sourcemapBaseUrl and use it) or clearly documenting that this option only applies to single-output configs.

@sourcery-ai sourcery-ai Bot Dec 8, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (code-quality): Invert ternary operator to remove negation (invert-ternary)

Suggested change
const sourcemapBaseUrl = !isArray(output) ? output?.sourcemapBaseUrl : undefined;
const sourcemapBaseUrl = isArray(output) ? undefined : output?.sourcemapBaseUrl;


ExplanationNegated conditions are more difficult to read than positive ones, so it is best
to avoid them where we can. By inverting the ternary condition and swapping the
expressions we can simplify the code.

finalConfig.options = {
...finalConfig.options,
sourceMap: true,
sourceMapMode: sourcemap === 'inline' ? 'inline' : 'separate',
...(sourcemapBaseUrl && { sourceMapBaseUrl: sourcemapBaseUrl }),
};
}
};
Expand Down
4 changes: 2 additions & 2 deletions src/utils/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ export function obfuscateBundle(finalConfig: Config, fileName: string, bundleIte
? {
...finalConfig.options,
inputFileName: fileName,
sourceMapFileName: `${fileName}.map`,
sourceMapFileName: `${path.basename(fileName)}.map`,
}
: finalConfig.options;
const obfuscated = javascriptObfuscator.obfuscate(bundleItem.code, fileSpecificOptions);
Expand Down Expand Up @@ -212,7 +212,7 @@ export function obfuscateLibBundle(finalConfig: Config, fileName: string, code:
? {
...finalConfig.options,
inputFileName: fileName,
sourceMapFileName: `${fileName}.map`,
sourceMapFileName: `${path.basename(fileName)}.map`,
}
: finalConfig.options;
const obfuscated = javascriptObfuscator.obfuscate(code, fileSpecificOptions);
Expand Down
3 changes: 2 additions & 1 deletion src/worker/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { parentPort } from 'node:worker_threads';
import path from 'node:path';
import javascriptObfuscator, { ObfuscatorOptions } from 'javascript-obfuscator';
import { composeSourcemaps, Log, ObfuscatedFilesRegistry } from '../utils';
import type { ObfuscationResult, WorkerMessage } from '../type';
Expand Down Expand Up @@ -28,7 +29,7 @@ if (parentPort) {
? {
...message.config.options,
inputFileName: fileName,
sourceMapFileName: `${fileName}.map`,
sourceMapFileName: `${path.basename(fileName)}.map`,
}
: message.config.options;
const obfuscated = javascriptObfuscator.obfuscate(bundleItem.code, fileSpecificOptions);
Expand Down