Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title! Playing around with
tyvm(which is awesome btw—thank you so much for making!) and somewhat buried in a flood of Rust optional warnings, mostly formatting stuff:I suppose I could just disable these locally, but these are pretty easy to fix and (I think) not super noisey — some actually unecessary imports, variables that can add an underscore because they aren't used, etc. Fixed all except for two locally (two which broke things when I moved around) and everything seemed to work properly. Here's the two I didn't patch:
(unless this is broken and also, LOL, I have tons of messages in projects like this)
Anyways, thinking the "build things completely in Typescript types" bit is really good and thinking I'll play around a bit over the holidays, just getting to peek now!