fix: add errors='ignore' to subprocess encoding for Windows compatibility #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity Fix Windows GBK/UTF-8 encoding conflict in get_current_app function. On Windows systems, ADB output may contain mixed encoding characters that cause UnicodeDecodeError. Adding errors='ignore' parameter allows the function to gracefully handle these encoding issues. Fixes zai-org#241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
errors='ignore'parameter tosubprocess.run()inget_current_app()functionProblem
On Windows systems, ADB output may contain mixed encoding characters that cause:
Solution
Add
errors='ignore'to thesubprocess.run()call to gracefully handle encoding issues.Fixes #241