fix: use binary mode in screenshot subprocess calls to avoid encoding errors #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… errors Change subprocess.run calls from text=True to text=False for screenshot operations. This prevents UnicodeEncodeError when handling binary PNG data or surrogate characters in ADB output. The output is now explicitly decoded with errors='replace' to gracefully handle any non-UTF-8 characters. Fixes zai-org#224
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
text=Truetotext=Falsein subprocess.run calls for screenshot operationserrors='replace'for error output handlingProblem
When capturing screenshots, the ADB commands may produce binary data or surrogate characters that cause:
Solution
Use binary mode (
text=False) for subprocess calls and decode output with proper error handling.Fixes #224