Skip to content

fix: Android 13+ compatibility for ADB Keyboard check #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JiajunBernoulli wants to merge 1 commit into
base: main
Choose a base branch
from
+25 −1
Open

fix: Android 13+ compatibility for ADB Keyboard check #392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,31 @@ def check_system_requirements(
)
ime_list = result.stdout.strip()

if "com.android.adbkeyboard/.AdbIME" in ime_list:
# Check if permission denied (Android 13+)
if "SecurityException" in result.stderr or "Permission" in result.stderr:
# Fallback: check if package is installed
pkg_result = subprocess.run(
[
"adb",
"shell",
"pm",
"list",
"packages",
"com.android.adbkeyboard",
],
capture_output=True,
text=True,
timeout=10,
)
if "com.android.adbkeyboard" in pkg_result.stdout:
print(
"✅ OK (package installed, please ensure enabled in settings)"
)
else:
print("❌ FAILED")
print(" Error: ADB Keyboard is not installed on the device.")
all_passed = False
elif "com.android.adbkeyboard/.AdbIME" in ime_list:
print("✅ OK")
else:
print("❌ FAILED")
Expand Down