Require Done status for closed Project items

[zaingulel]

Outcome

• Move the returning-customer Booking History criterion from completed Enforce role-safe customer, owner and administrator access #20 to open Show booking history and send preparation reminders #37 in the checked-in tracker contract.
• Require every closed Project item to use Done.
• Add mutation-sensitive verifier tests and document the lifecycle invariant.

Root cause

The verifier treated only Ready, In progress, and In review as invalid for closed issues, so a closed item could remain in Backlog without failing. The repository manifest also still reflected the criterion’s old issue placement after the live tracker was reconciled.

Verification

• npm run verify:board — passed
• npm run verify — passed
• 383 Vitest tests
• 103 PostgreSQL tests
• 24 access journeys
• 14 marketplace journeys
• production Worker build, secret scan, generated types, and Worker smoke passed
• independent Standards review: no findings
• independent Spec review: no findings

Impact

Tracker verification only. No runtime product behavior, security/privacy boundary, database migration, or visible interface changes.

Summary by CodeRabbit

• Bug Fixes

  • Updated project status validation so closed issues must be marked Done.
  • Prevented blocked open issues from being assigned active statuses.
  • Corrected the assignment of Booking History acceptance criteria to the appropriate issue.

• Tests

  • Added coverage for invalid statuses on closed issues.
  • Added validation for acceptance criteria across issue and project item descriptions.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7f275c77-c003-4405-a298-7586e1d33f84

📥 Commits

Reviewing files that changed from the base of the PR and between 2590de2 and 2542117.

📒 Files selected for processing (3)

• docs/agents/issue-tracker.md
• scripts/lib/rentcottage-project-contract.mjs
• scripts/verify-rentcottage-project.test.mjs

---

📝 Walkthrough

Walkthrough

The project contract now requires all non-open issues to use Done. The returning-customer criterion moved from issue 20 to issue 37. Documentation and verifier tests reflect these rules.

Changes

Project contract verification

Layer / File(s)	Summary
Update project contract rules scripts/lib/rentcottage-project-contract.mjs, docs/agents/issue-tracker.md	The contract requires non-open issues to use Done. The returning-customer criterion now belongs to issue 37. The issue-tracker guidance reflects the separate status rules.
Add verifier regression coverage scripts/verify-rentcottage-project.test.mjs	Tests reject closed issues in Backlog and validate acceptance criteria across issue and Project item bodies.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 25421

This change tightens Project-item status verification and updates the checked-in tracker contract without changing runtime product behavior; no actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

• zaingulel/RentCottage#54: Directly updates the same project-status and acceptance-criteria verifier rules.
• zaingulel/RentCottage#70: Modifies related project-status and acceptance-criteria validation rules.
• zaingulel/RentCottage#67: Updates the acceptance-criteria contract in the same contract module.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: requiring closed Project items to use Done status.
Description check	✅ Passed	The description clearly states the outcome, root cause, impact, and verification results, and it is relevant to the changes.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/closed-project-items-must-be-done

---

_{Comment @coderabbitai help to get the list of available commands.}