Skip to content

[draft] Support for Python 3.10 #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,13 @@ envset/
*.whl
.tmp/

# virtual environments
.env
.venv*
env/
venv/
ENV/

# built files
dist/
coverage/
Expand All @@ -32,4 +39,7 @@ node_modules/
docs/iJO1366.json
docs/e_coli_core.json
docs/iAB_RBC_283.json
docs/example_map.html
docs/example_map.html

# intellij
.idea/
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
6.17.1
18 changes: 10 additions & 8 deletions DEPLOY.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
# npm

update version in package.json
yarn clean
yarn install
yarn build
yarn copy # for docs to build
git commit version change
git tag version
git push commit & tags
source .venv/bin/activate
nvm use
(update version in package.json)
npm run clean
npm install
npm run build
npm run copy # for docs to build
git commit -m "version change"
git tag <version>
git push
npm login # last time i tried, yarn wasn't working for login & publish
npm publish

Expand Down
15 changes: 14 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,12 @@ First, install dependencies with [npm](https://www.npmjs.com) (or you can use
[yarn](https://yarnpkg.com)):

```
brew install nvm pyenv
pyenv install 3.10.12
pyenv shell 3.10.12
python -m venv .venv
source .venv/bin/activate
nvm use
npm install
```

Expand Down Expand Up @@ -126,7 +132,14 @@ Then in the `py` directory, install the Python package:

```
cd py
pip install -e . # installs escher in develop mode and dependencies
pip install -r requirements.txt
pip install -e . # installs escher in develop mode
```

To use the widgets within notebooks from jupyterlab, you also need to run the following from the escher root directory:
```bash
jupyter labextension install @jupyter-widgets/jupyterlab-manager
jupyter labextension install escher
```

For Python testing, run this in the `py` directory:
Expand Down
3 changes: 2 additions & 1 deletion appveyor.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
environment:
matrix:
- python: 'C:\\Python37-x64'
- python: 'C:\\Python310-x64'

install:
# Add python to PATH
Expand All @@ -9,6 +9,7 @@ install:
# Install python packages
- python -m pip install --upgrade pip
- cd py
- python -m pip install -r requirements.txt
- python -m pip install -e .
- cd ..

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "escher",
"author": "Zachary King",
"version": "1.7.3",
"version": "1.8.0",
"post_version": null,
"schema_version": "1-0-0",
"map_model_version": "6",
Expand Down
4 changes: 2 additions & 2 deletions py/escher/static/escher.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion py/escher/static/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "escher",
"author": "Zachary King",
"version": "1.7.3",
"version": "1.8.0",
"post_version": null,
"schema_version": "1-0-0",
"map_model_version": "6",
Expand Down
Loading