Fix for 'avoidNamespaces' field updates #157
Conversation
| @@ -50,8 +50,9 @@ def on_delete( | |||
| logger.debug(f'csec {uid} deleted from memory ok') | |||
|
|
|||
|
|
|||
| @kopf.on.field('clustersecret.io', 'v1', 'clustersecrets', field='avoidNamespaces') | |||
There was a problem hiding this comment.
Do you think we could have a conformance test ensuring this change work as expected ?
There was a problem hiding this comment.
Do you think we could have a conformance test ensuring this change work as expected ?
Yes, we can have some test. I will check current tests and try to add something there.
|
While writing test for 'avoidNamespaces' I found a big bug. If the 'ClusterSecret' object previously did not contain 'matchNamespace' or 'avoidNamespaces' fields, the 'on_fields_avoid_or_match_namespace' function would ignore the event. It was the same before my changes, but I will rewrite the logic and then will update this PR |
tr-aheiev
force-pushed
the
fix-avoidnamespaces-changes
branch
from
01c0bb0 to
e4489b4
Compare
|
Code updated. |
…mespaces' was missing before they updates Removed unnecessary cache checking - it always will be empty for 'resume' and 'create' events
tr-aheiev
force-pushed
the
fix-avoidnamespaces-changes
branch
from
e4489b4 to
3e1fadc
Compare
|
Another update to last changes in master and bumped helm chart version to pass the tests. |
|
All tests are ✅ merging |
This is simple fix for issue 93. It adds an additional '@kopf.on.field' decorator for update events on 'avoidNamespaces' field. After this PR all tests are passed successfully.