feat: add shortcuts for greek letters and primes#71
Merged
Conversation
Closed
Contributor
Author
click on buttons bellow the input directly call |
Deploying react-ocl with
|
| Latest commit: |
090cd7f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://637095ba.react-ocl.pages.dev |
| Branch Preview URL: | https://61-custom-labels-and.react-ocl.pages.dev |
Contributor
Author
Proposal: greek letters with two lines
|
Contributor
|
Sorry I was not precise enough but it should not close the dialog box. It should just append the symbol in the input box. We may want to enter α' so we need to make 2 click (α + ') and then validate the input text box. |
Contributor
|
But yes it looks great ! |
Contributor
Author
|
tpoisseau
force-pushed
the
61-custom-labels-and-ɑ-β
branch
from
520bf84 to
bce0e27
Compare
Contributor
Author
|
@lpatiny I let you review, I kept the last proposal as you ask on DM, and I replace text selection instead call onSubmit |
Contributor
|
Next number is broken. Seems the input is not taken into account anymore.
|
Contributor
Author
lpatiny
approved these changes
Dec 12, 2025
Contributor
lpatiny
left a comment
lpatiny
left a comment
There was a problem hiding this comment.
I would prefer not to have a release before the next prime, double prime, triple prime issue is solved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #61