Skip to content

feat: add options to customize the number of grid lines in select ROIs#170

Merged
stropitek merged 1 commit intomainfrom
variable-grid-size
Nov 14, 2025
Merged

feat: add options to customize the number of grid lines in select ROIs#170
stropitek merged 1 commit intomainfrom
variable-grid-size

Conversation

@stropitek
Copy link
Contributor

This will be helpful to guide rotation of ROI to make them straight

@stropitek stropitek requested a review from tpoisseau November 14, 2025 09:42
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 14, 2025

Deploying react-roi with  Cloudflare Pages  Cloudflare Pages

Latest commit: a26f234
Status: ✅  Deploy successful!
Preview URL: https://2a703ecc.react-roi.pages.dev
Branch Preview URL: https://variable-grid-size.react-roi.pages.dev

View logs

Copy link
Contributor

@tpoisseau tpoisseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM
It would be great to have props to style grid lines (line width, transparency, color, patterns like dots or dash). It can be done in another PR.

@stropitek
Copy link
Contributor Author

It would be great to have props to style grid lines (line width, transparency, color, patterns like dots or dash). It can be done in another PR.

It already exists to some extent. But it is implemented in a callback, therefore there are no controls in the stories to set them. There is an option to set the color of the size controls in the corners, and grid lines take the same color, and a separate option to set grid lines opacity specifically.

@stropitek stropitek merged commit ba318fc into main Nov 14, 2025
10 checks passed
@stropitek stropitek deleted the variable-grid-size branch November 14, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants