feat: add options to customize the number of grid lines in select ROIs#170
Merged
feat: add options to customize the number of grid lines in select ROIs#170
Conversation
Deploying react-roi with
|
| Latest commit: |
a26f234
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2a703ecc.react-roi.pages.dev |
| Branch Preview URL: | https://variable-grid-size.react-roi.pages.dev |
tpoisseau
approved these changes
Nov 14, 2025
Contributor
tpoisseau
left a comment
There was a problem hiding this comment.
SGTM
It would be great to have props to style grid lines (line width, transparency, color, patterns like dots or dash). It can be done in another PR.
Contributor
Author
It already exists to some extent. But it is implemented in a callback, therefore there are no controls in the stories to set them. There is an option to set the color of the size controls in the corners, and grid lines take the same color, and a separate option to set grid lines opacity specifically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be helpful to guide rotation of ROI to make them straight