Skip to content

feat(TanstackForm): export multiple input to be used in projects#974

Merged
Sebastien-Ahkrin merged 3 commits intomainfrom
fix-deps-export
Feb 5, 2026
Merged

feat(TanstackForm): export multiple input to be used in projects#974
Sebastien-Ahkrin merged 3 commits intomainfrom
fix-deps-export

Conversation

@Sebastien-Ahkrin
Copy link
Contributor

  • Change name of Input to avoid collision with other components. (Added a prefix)
  • Export every input to outside of the project
  • Export Section to be used outside of the project

BREAKING CHANGE: Input component from Tanstack has changed name. They are now prefixed with Input

* Change name of Input to avoid collision with other components. (Added a prefix)
* Export every input to outside of the project
* Export Section to be used outside of the project

BREAKING CHANGE: Input component from Tanstack has changed name. They are now prefixed with `Input`
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 5, 2026

Deploying react-science with  Cloudflare Pages  Cloudflare Pages

Latest commit: dc21583
Status: ✅  Deploy successful!
Preview URL: https://614b42a1.react-science.pages.dev
Branch Preview URL: https://fix-deps-export.react-science.pages.dev

View logs

Copy link
Contributor

@tpoisseau tpoisseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try to export only the types ?

Because theses inputs should not be used directly. They must be use with form (<form.Input>) not directly <Input>.

Also, it is not a breaking change, you did not rename the components but added exports (with name different than original component name).

example of what I expect if it works:

export type { Input as _TanstackInput } from './input.js';

user of react-science should not needs to import theses types, but a name is needed for export const FormSectionA = withForm({/*...*/}). So type to export only the type, _ to signify it's private, and Tanstack prefix to avoid collision.

Copy link
Contributor

@tpoisseau tpoisseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sebastien-Ahkrin Sebastien-Ahkrin merged commit 56bbf46 into main Feb 5, 2026
14 checks passed
@Sebastien-Ahkrin Sebastien-Ahkrin deleted the fix-deps-export branch February 5, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants