In-code kubectl apply #767
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkeloscar
added
do-not-merge
minor
mikkeloscar
force-pushed
the
kubectl-apply
branch
from
0eb8125 to
0a5c98f
Compare
mikkeloscar
force-pushed
the
kubectl-apply
branch
2 times, most recently
from
20f40d1 to
f2cd750
Compare
mikkeloscar
force-pushed
the
kubectl-apply
branch
from
f2cd750 to
d124d76
Compare
mikkeloscar
force-pushed
the
kubectl-apply
branch
from
d124d76 to
abed1e2
Compare
mikkeloscar
force-pushed
the
kubectl-apply
branch
from
abed1e2 to
d8c7595
Compare
mikkeloscar
force-pushed
the
kubectl-apply
branch
2 times, most recently
from
31b264b to
ec9ed09
Compare
mikkeloscar
force-pushed
the
kubectl-apply
branch
2 times, most recently
from
99333c1 to
982953b
Compare
mikkeloscar
force-pushed
the
kubectl-apply
branch
3 times, most recently
from
77377f8 to
b0bd34f
Compare
Does this require us to run any tests? I think it's fine to rollout this change and observe after a while, to check this concurrency requirement. Otherwise, PR looks good 👍 |
mikkeloscar
force-pushed
the
kubectl-apply
branch
from
b0bd34f to
cd1576f
Compare
Yes, this we can best observe after rolling it out and enabling it in some clusters. |
|
👍 |
mikkeloscar
force-pushed
the
kubectl-apply
branch
from
cd1576f to
d0a458b
Compare
mikkeloscar
force-pushed
the
kubectl-apply
branch
from
d0a458b to
0225b7d
Compare
mikkeloscar
force-pushed
the
kubectl-apply
branch
from
0225b7d to
41e91bc
Compare
mikkeloscar
force-pushed
the
kubectl-apply
branch
from
41e91bc to
fcfc072
Compare
mikkeloscar
force-pushed
the
kubectl-apply
branch
from
fcfc072 to
1e49116
Compare
mikkeloscar
force-pushed
the
kubectl-apply
branch
from
1e49116 to
f17a821
Compare
|
👍 |
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
mikkeloscar
force-pushed
the
kubectl-apply
branch
from
f17a821 to
abce16b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of Concept of porting the "kubectl apply" code from deployment-service to also utilize it in CLM. Basically this means making the
kubectl applyoperation via Go instead of calling the externalkubectlbinary.The motivation for this change is that we currently restrict how many executions of
kubectl applywe do concurrently as it's hard to control the memory. This has the side effect of limiting how many clusters we can process in parallel. The idea is that by having this in go we save memory by not having to run another process and we thus can do more in parallel.The feature is behind a config-item
kubectl_apply_inline: truewhich enables us to configure it only in a few clusters as a start to validate that it behaves as expected and gives the intended benefits.TODO
Check if we still need to control concurrency.