Use cluster-registry client provided by the upstream repository #868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linki
added
the
minor
Signed-off-by: Martin Linkhorst <[email protected]>
linki
force-pushed
the
use-upstream-cluster-registry-client
branch
from
17b320a to
625eec7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now use the
cluster-registryclient from the cluster-registry project (or any other central library).The goal is to unify several projects and have them use a single
cluster-registryclient implementation shared between them. In this first step it only extracts the generated part of it. However, we do also have a wrapper that adds certain convenience functions. If these were also extracted into a central library, other projects could also use them and we would have a unified and easy way to accesscluster-registrythroughout our projects.Other higher-level functionality like asynchronous refreshing a local list of clusters from
deployment-servicecould also be part of a centralcluster-registryabstraction library.