This repository was archived by the owner on Jun 7, 2024. It is now read-only.
ARUHA-2328: added tmp script for removing locks of deleted subscriptions;#1057
Open
v-stepanov wants to merge 4 commits intomasterfrom
Open
ARUHA-2328: added tmp script for removing locks of deleted subscriptions;#1057v-stepanov wants to merge 4 commits intomasterfrom
v-stepanov wants to merge 4 commits intomasterfrom
Conversation
antban
reviewed
Jun 7, 2019
|
|
||
| int notExists = 0; | ||
| for (int i = 0; i < locks.size(); i++) { | ||
| System.out.println((i * 100 / (locks.size() - 1)) + "%"); |
Contributor
There was a problem hiding this comment.
And it reports 100 before executing action
antban
reviewed
Jun 7, 2019
| final String contextPath = "/staging"; | ||
|
|
||
| final List<String> locks = zk.getChildren(contextPath + "/nakadi/locks", false); | ||
| final List<String> subscriptions = zk.getChildren(contextPath + "/nakadi/subscriptions", false); |
Contributor
There was a problem hiding this comment.
10000 subscriptions, 100000 locks. It makes sense to use HashSet for subscriptions
Contributor
|
But honestly - I don't care about this script, cause it will not be merged |
Contributor
Author
|
@antban I addressed all the terrible problems of this script; |
antban
reviewed
Jun 11, 2019
| import java.util.List; | ||
| import java.util.Set; | ||
|
|
||
| public class SubscriptionLocksCleaner { |
Contributor
There was a problem hiding this comment.
Please document additional VM arguments that should be used to run this thing.
Contributor
|
👍 |
Contributor
|
@v-stepanov Are you still here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARUHA-2328: added tmp script for removing locks of deleted subscriptions;