Correctly format URLs when address is IPv6#1104
Closed
mikkeloscar wants to merge 1 commit intozalando:masterfrom
Closed
Correctly format URLs when address is IPv6#1104mikkeloscar wants to merge 1 commit intozalando:masterfrom
mikkeloscar wants to merge 1 commit intozalando:masterfrom
Conversation
Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
FxKu
added
the
bugfix
FxKu
reviewed
Apr 8, 2025
|
|
||
| def format_url(host, port): | ||
| if ":" in host: | ||
| return "[" + host + "]" + ":" + port |
Member
Author
There was a problem hiding this comment.
Yes, if a host (without port) has : in it it indicates IPv6 address and we add the [] if not we leave it as is.
(I was testing this change internally to validate that it works, hence the PR was in draft, it probably changed when you commented)
Member
Author
|
Closing as this change doesn't seem to be relevant/needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an IPv6 address includes port it must be formatted with surrounding
[]This adds logic to optionally add surrounding
[]if the IP address is IPv6.