fix(driver): separate embedded env-var pairs with a record separator#11
Open
jakobjung10 wants to merge 1 commit into
Open
fix(driver): separate embedded env-var pairs with a record separator#11jakobjung10 wants to merge 1 commit into
jakobjung10 wants to merge 1 commit into
Conversation
The external-mutant env-var table joined every key and value with a single `\x1F` separator and decoded it with `array_chunks::<2>`. Some values, such as `MUTEST_ENCODED_ARGS`, themselves contain `\x1F`, which misaligned the key/value pairing and could restore the wrong variables. Separate pairs with `\x1E` and keep `\x1F` only between a key and its value, decoding with `split_once`. Drop the now-unused `iter_array_chunks` feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The external-mutant env-var table joined every key and value with a single
\x1Fseparator and decoded it witharray_chunks::<2>. Some values, such asMUTEST_ENCODED_ARGS, themselves contain\x1F, which misaligned the key/value pairing and could restore the wrong variables.Separate pairs with
\x1Eand keep\x1Fonly between a key and its value, decoding withsplit_once. Drop the now-unusediter_array_chunksfeature.