fix(driver): canonicalize target src_path before matching input file#12
Open
jakobjung10 wants to merge 1 commit into
Open
fix(driver): canonicalize target src_path before matching input file#12jakobjung10 wants to merge 1 commit into
jakobjung10 wants to merge 1 commit into
Conversation
The Cargo target lookup compared the canonicalized rustc input path against `target.src_path` from Cargo metadata, which is not canonicalized. On Windows canonicalization prepends a `\?\` verbatim prefix, so the plain equality never matched and target resolution panicked. Canonicalize `src_path` at the comparison site so both sides are in the same form; a `src_path` that fails to canonicalize is treated as a non-match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Cargo target lookup compared the canonicalized rustc input path against
target.src_pathfrom Cargo metadata, which is not canonicalized. On Windows canonicalization prepends a\?\verbatim prefix, so the plain equality never matched and target resolution panicked.Canonicalize
src_pathat the comparison site so both sides are in the same form; asrc_paththat fails to canonicalize is treated as a non-match.