fix(emit): gate std/alloc injection on loaded crates instead of #![no_std]#14
Open
jakobjung10 wants to merge 1 commit into
Open
fix(emit): gate std/alloc injection on loaded crates instead of #![no_std]#14jakobjung10 wants to merge 1 commit into
jakobjung10 wants to merge 1 commit into
Conversation
…_std] The prelude-attr and crate-ref injection decided whether to add std-only features and an `extern crate alloc` by sniffing for a `#![no_std]` attribute. That attribute does not reliably survive to this expansion stage (notably during external-mutant recompilation of a no_std crate), so std features were injected into no_std crates and failed to compile. Check `used_crates` for the actually-loaded std/alloc crate instead, matching the existing `liballoc_internals` gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prelude-attr and crate-ref injection decided whether to add std-only features and an
extern crate allocby sniffing for a#![no_std]attribute. That attribute does not reliably survive to this expansion stage (notably during external-mutant recompilation of a no_std crate), so std features were injected into no_std crates and failed to compile.Check
used_cratesfor the actually-loaded std/alloc crate instead, matching the existingliballoc_internalsgate.