Skip to content

fix(emit): wrap no_mangle-family attrs as unsafe for edition-2024 round-trip #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakobjung10 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(emit): wrap no_mangle-family attrs as unsafe for edition-2024 round-trip #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion mutest-emit/src/codegen/hygiene.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1514,7 +1514,19 @@ impl<'tcx, 'op> ast::mut_visit::MutVisitor for MacroExpansionSanitizer<'tcx, 'op
if is_macro_helper_attr(&self.syntax_extensions, attr) {
// Disable attribute by overriding it with an empty doc-comment.
// This is easier than modifying every visit function to properly remove the attribute nodes.
attr.kind = ast::AttrKind::DocComment(ast::token::CommentKind::Line, sym::empty)
attr.kind = ast::AttrKind::DocComment(ast::token::CommentKind::Line, sym::empty);
return;
}

// In Rust 2024 `no_mangle`/`export_name`/`link_section` must be written as `unsafe(...)`.
// Macros from earlier-edition crates can emit the bare form, which is invalid once the
// generated crate is recompiled at the 2024 edition; wrap it to keep the round-trip valid.
if self.tcx.sess.edition().at_least_rust_2024()
&& (attr.has_name(sym::no_mangle) || attr.has_name(sym::export_name) || attr.has_name(sym::link_section))
&& let ast::AttrKind::Normal(normal) = &mut attr.kind
&& let ast::Safety::Default = normal.item.unsafety
{
normal.item.unsafety = ast::Safety::Unsafe(DUMMY_SP);
}
}

Expand Down