feat: improve polling server task status #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var lastStatus: String? | ||
|
|
||
| while true { | ||
| let statusResponse = try await Network.shared.getStatus(for: serverTask, id: taskID, uid: uid) |
Collaborator
There was a problem hiding this comment.
where do you exit this while true loop ?
kcelia
reviewed
May 22, 2025
| self.status = .progress("Analyzing sleep quality…") | ||
| case "reserved", "queued": | ||
| self.status = .progress("Task is in queue") | ||
| case "pending", "failure", "revoked", "unknown", "error": |
Contributor
There was a problem hiding this comment.
In our design, we added the cancel_task endpoint, which returns the status revoked.
it's a manual cancellation initiated by the user and should not be considered an error.
kcelia
reviewed
May 22, 2025
| if statusResponse.status != lastStatus { | ||
| lastStatus = statusResponse.status | ||
| switch statusResponse.status { | ||
| case "started": |
kcelia
reviewed
May 22, 2025
| case "completed", "success": | ||
| self.resultURL = try await getServerResult(uid: uid, taskID: taskID, for: date) | ||
| self.status = nil | ||
| break |
Contributor
There was a problem hiding this comment.
does it exit the 'switch' or the 'while' loop ?
Contributor
There was a problem hiding this comment.
i m not familiar with swift, maybe 'return' is more suited
kcelia
reviewed
May 22, 2025
| self.resultURL = try await getServerResult(uid: uid, taskID: taskID, for: date) | ||
| self.status = nil | ||
| break | ||
| default: break |
Contributor
There was a problem hiding this comment.
maybe you should throw an error if we don't know the status of:
default:
throw TaskError.unexpectedStatus(statusResponse.status)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.