feat(gateway-contracts): introduce the custodians as part of the backup feature#122
Conversation
c3f164e to
b0c1ce3
Compare
melanciani
left a comment
There was a problem hiding this comment.
looks great ! just have one question for the MPC team to clarify before we can merge this
melanciani
left a comment
There was a problem hiding this comment.
actually, regarding what we've discussed in #142, we now would need to consider versioning the contracts and anticipate upgrading them
b0c1ce3 to
2ab012d
Compare
melanciani
left a comment
There was a problem hiding this comment.
sorry, a few things has changed, in the end :
- https://github.com/zama-ai/fhevm/issues/247 will need to be done before
- as updated in https://github.com/zama-ai/fhevm/issues/222, we actually won't consider multiple files for different versions, only the latest one
melanciani
left a comment
There was a problem hiding this comment.
also please update the test suite and make sure sure e2e tests pass with your changes
2564008 to
da6639a
Compare
gateway-contracts/contracts/examples/GatewayConfigUpgradedExample.sol
Outdated
Show resolved
Hide resolved
melanciani
left a comment
There was a problem hiding this comment.
sorry, realized we are missing a safeguard regarding updates, better to consider it before continuing this PR imo : https://github.com/zama-ai/fhevm/issues/261
wdyt ?
a7efe61 to
b8e6aed
Compare
…for reinitializeV2
a65634a to
b09e943
Compare
melanciani
left a comment
There was a problem hiding this comment.
thanks ! I spotted a few missing details + you might want to merge the upgrade PR + rebase
Missed methods and tests for custodians pushed in the last commit 🙏 |
melanciani
left a comment
There was a problem hiding this comment.
alright, thanks a lot !!
fix: remove 'Sup' in the list of greetings prefix
* fix: add sqlite3 to Runtime image * chore: update Cargo.lock
This PR only introduces the custodians' metadata and initialization. As part of the backup feature, there are other incoming implementations regarding the different phases of the backup logic:
Closes zama-ai/fhevm-internal#137