Skip to content

feat(gateway-contracts): introduce the custodians as part of the backup feature#122

Merged
isaacdecoded merged 16 commits intomainfrom
isaac/111/feat/introduce-backup-logic
Jun 18, 2025
Merged

feat(gateway-contracts): introduce the custodians as part of the backup feature#122
isaacdecoded merged 16 commits intomainfrom
isaac/111/feat/introduce-backup-logic

Conversation

@isaacdecoded
Copy link
Copy Markdown
Contributor

@isaacdecoded isaacdecoded commented Jun 2, 2025

This PR only introduces the custodians' metadata and initialization. As part of the backup feature, there are other incoming implementations regarding the different phases of the backup logic:

  1. Setup/Update custodians phase (implies a KMS context refresh)
  2. Key backup phase (receives signatures and emit backup completed event)
  3. Recover shares phase (requires multi sig)
  4. Dry run phase

Closes zama-ai/fhevm-internal#137

@isaacdecoded isaacdecoded changed the title Isaac/111/feat/introduce backup logic feat(gateway-contracts): introduce the custodians as part of the backup feature Jun 2, 2025
@isaacdecoded isaacdecoded force-pushed the isaac/111/feat/introduce-backup-logic branch 2 times, most recently from c3f164e to b0c1ce3 Compare June 10, 2025 13:55
@isaacdecoded isaacdecoded marked this pull request as ready for review June 10, 2025 14:01
@isaacdecoded isaacdecoded requested a review from melanciani June 10, 2025 14:01
Copy link
Copy Markdown
Contributor

@melanciani melanciani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great ! just have one question for the MPC team to clarify before we can merge this

Copy link
Copy Markdown
Contributor

@melanciani melanciani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, regarding what we've discussed in #142, we now would need to consider versioning the contracts and anticipate upgrading them

@isaacdecoded isaacdecoded force-pushed the isaac/111/feat/introduce-backup-logic branch from b0c1ce3 to 2ab012d Compare June 11, 2025 14:17
Copy link
Copy Markdown
Contributor

@melanciani melanciani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, a few things has changed, in the end :

Copy link
Copy Markdown
Contributor

@melanciani melanciani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also please update the test suite and make sure sure e2e tests pass with your changes

@isaacdecoded isaacdecoded force-pushed the isaac/111/feat/introduce-backup-logic branch from 2564008 to da6639a Compare June 13, 2025 08:01
@isaacdecoded isaacdecoded requested a review from melanciani June 13, 2025 09:34
Copy link
Copy Markdown
Contributor

@melanciani melanciani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, realized we are missing a safeguard regarding updates, better to consider it before continuing this PR imo : https://github.com/zama-ai/fhevm/issues/261

wdyt ?

@isaacdecoded isaacdecoded force-pushed the isaac/111/feat/introduce-backup-logic branch from a7efe61 to b8e6aed Compare June 17, 2025 09:28
@isaacdecoded isaacdecoded force-pushed the isaac/111/feat/introduce-backup-logic branch from a65634a to b09e943 Compare June 18, 2025 08:23
@isaacdecoded isaacdecoded requested a review from melanciani June 18, 2025 10:57
Copy link
Copy Markdown
Contributor

@melanciani melanciani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks ! I spotted a few missing details + you might want to merge the upgrade PR + rebase

@isaacdecoded
Copy link
Copy Markdown
Contributor Author

thanks ! I spotted a few missing details + you might want to merge the upgrade PR + rebase

Missed methods and tests for custodians pushed in the last commit 🙏

@isaacdecoded isaacdecoded requested a review from melanciani June 18, 2025 15:26
Copy link
Copy Markdown
Contributor

@melanciani melanciani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, thanks a lot !!

@isaacdecoded isaacdecoded merged commit b455d1c into main Jun 18, 2025
70 checks passed
@isaacdecoded isaacdecoded deleted the isaac/111/feat/introduce-backup-logic branch June 18, 2025 16:03
paulo-zama pushed a commit that referenced this pull request Mar 26, 2026
fix: remove 'Sup' in the list of greetings prefix
paulo-zama pushed a commit that referenced this pull request Mar 26, 2026
* fix: add sqlite3 to Runtime image

* chore: update Cargo.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants