ci: add additional clippy lints for clone operations#1256
Closed
Himess wants to merge 1 commit intozama-ai:mainfrom
Closed
ci: add additional clippy lints for clone operations#1256Himess wants to merge 1 commit intozama-ai:mainfrom
Himess wants to merge 1 commit intozama-ai:mainfrom
Conversation
Add clippy::clone_on_copy and clippy::unnecessary_to_owned checks to prevent unnecessary clone operations as suggested in code review. Related to zama-ai#1169
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
clippy::clone_on_copyandclippy::unnecessary_to_ownedchecks to prevent unnecessary clone operations.Follow-up to #1169 as suggested ref : #1169 (comment)