Skip to content

feat(protocol-contracts): improve fees management in staking contracts#1482

Merged
melanciani merged 7 commits intomainfrom
melanciani/716/protocol-contracts/improve_owner_fees
Dec 11, 2025
Merged

feat(protocol-contracts): improve fees management in staking contracts#1482
melanciani merged 7 commits intomainfrom
melanciani/716/protocol-contracts/improve_owner_fees

Conversation

@melanciani
Copy link
Copy Markdown
Contributor

@melanciani melanciani requested a review from a team as a code owner December 5, 2025 14:25
@cla-bot cla-bot Bot added the cla-signed label Dec 5, 2025
@melanciani melanciani requested a review from jatZama December 5, 2025 14:27
@melanciani melanciani force-pushed the melanciani/716/protocol-contracts/improve_owner_fees branch from 7ba4fdf to df917b7 Compare December 5, 2025 17:16
Comment thread protocol-contracts/staking/contracts/OperatorStaking.sol
Comment thread protocol-contracts/staking/tasks/deposit.ts Outdated
Comment thread protocol-contracts/staking/tasks/setFee.ts
Comment thread protocol-contracts/staking/tasks/setFee.ts
Comment thread protocol-contracts/staking/contracts/OperatorRewarder.sol Outdated
Comment thread protocol-contracts/staking/contracts/OperatorRewarder.sol Outdated
@melanciani melanciani requested review from arr00 and jatZama December 10, 2025 10:19
@mergify
Copy link
Copy Markdown

mergify Bot commented Dec 10, 2025

🧪 CI Insights

Here's what we observed from your CI run for 4e65ff1.

🟢 All jobs passed!

But CI Insights is watching 👀

Comment thread protocol-contracts/staking/contracts/OperatorRewarder.sol
Comment thread protocol-contracts/staking/contracts/OperatorRewarder.sol Outdated
Comment thread protocol-contracts/staking/contracts/OperatorRewarder.sol Outdated
@arr00
Copy link
Copy Markdown
Collaborator

arr00 commented Dec 10, 2025

Who will be the owner? Is this going to be a trusted party or governance system? In that case, should we consider upgradeability here?

Upgradeability was initially ruled out as allowing the operator themselves to control that would be far too permissive.

@melanciani
Copy link
Copy Markdown
Contributor Author

melanciani commented Dec 10, 2025

Who will be the owner? Is this going to be a trusted party or governance system? In that case, should we consider upgradeability here?

Upgradeability was initially ruled out as allowing the operator themselves to control that would be far too permissive.

the owner will be a governance DAO system, so yes it does make sense to consider upgradability in the end ! I will add it in a follow-up PR

btw note that in #1540 we make the owner of ProtocolStaking the owner of OperatorStaking and OperatorRewarder ! thanks for the suggestion

@melanciani melanciani force-pushed the melanciani/716/protocol-contracts/improve_owner_fees branch from ce8dc31 to 32abf73 Compare December 10, 2025 17:33
Comment thread protocol-contracts/staking/contracts/OperatorRewarder.sol Outdated
Comment thread protocol-contracts/staking/contracts/OperatorRewarder.sol Outdated
@melanciani melanciani force-pushed the melanciani/716/protocol-contracts/improve_owner_fees branch from 8b4eb3f to 4e65ff1 Compare December 11, 2025 10:03
@melanciani melanciani merged commit 68699af into main Dec 11, 2025
66 checks passed
@melanciani melanciani deleted the melanciani/716/protocol-contracts/improve_owner_fees branch December 11, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants