feat(coprocessor): add a non-blocking, distributed locking mechanism across multiple tfhe-workers#1506
Closed
feat(coprocessor): add a non-blocking, distributed locking mechanism across multiple tfhe-workers#1506
Conversation
obatirou
reviewed
Dec 9, 2025
rudy-6-4
reviewed
Dec 9, 2025
rudy-6-4
reviewed
Dec 9, 2025
goshawk-3
force-pushed
the
georgi/tfhe-worker/dependence_chain_id
branch
from
762c51d to
70e2cd6
Compare
goshawk-3
changed the title
goshawk-3
force-pushed
the
georgi/tfhe-worker/dependence_chain_id
branch
from
70e2cd6 to
07b980f
Compare
obatirou
reviewed
Dec 10, 2025
obatirou
reviewed
Dec 10, 2025
🧪 CI InsightsHere's what we observed from your CI run for b206f87. 🟢 All jobs passed!But CI Insights is watching 👀 |
antoniupop
reviewed
Dec 11, 2025
| ORDER BY schedule_order | ||
| LIMIT $1 | ||
| LIMIT $2 | ||
| ) as c_schedule_order |
Collaborator
There was a problem hiding this comment.
I would say at some point we won't need the union here (probably not even need the schedule order anymore as that would be the role of the last_updated_at in a sense), but can keep for now. We'll have to refactor/simplify this handling, but we need to think of a way to deal with missing events wrt. dependence chain selection as well at some point. If there's "lots" of workers it's less of a problem as only some would be stuck
…iple workers It provides a non-blocking, distributed locking mechanism that coordinates dependence-chain processing across multiple tfhe-workers. A worker can acquire ownership of the next available dependence-chain entry for processing ordered by last_updated_at (FIFO queue-like approach). Ownership expires after a timeout, enabling work-stealing by other workers. New CLI param --worker_id
- Added LockingReason for logging - Make expiry configurable
- add --dcid_ttl_sec config - add otel traces for dcid
goshawk-3
force-pushed
the
georgi/tfhe-worker/dependence_chain_id
branch
from
4618e0d to
b206f87
Compare
Contributor
Author
|
Closed as duplicate #1550 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a non-blocking, distributed locking mechanism that coordinates dependence-chain processing across tfhe-workers replicas.
A worker can acquire a lock of the next available dependence-chain entry for processing ordered by last_updated_at (FIFO queue-like approach).
Ownership expires after a timeout, enabling work-stealing by other workers for resilience.
New CLI params