Skip to content

Fix tests #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arr00 wants to merge 2 commits into from
Closed

Fix tests #1566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29663f8
Fix permit tests
arr00 Dec 12, 2025
ca6a143
fix lint
arr00 Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions protocol-contracts/staking/contracts/OperatorStaking.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@

pragma solidity ^0.8.27;

import {UUPSUpgradeable} from "@openzeppelin/contracts/proxy/utils/UUPSUpgradeable.sol";
import {IERC20} from "@openzeppelin/contracts/interfaces/IERC20.sol";
import {IERC20Permit} from "@openzeppelin/contracts/token/ERC20/extensions/IERC20Permit.sol";
import {ERC1363Upgradeable} from "@openzeppelin/contracts-upgradeable/token/ERC20/extensions/ERC1363Upgradeable.sol";
import {IERC20} from "@openzeppelin/contracts/interfaces/IERC20.sol";
import {UUPSUpgradeable} from "@openzeppelin/contracts/proxy/utils/UUPSUpgradeable.sol";
import {ERC4626, IERC4626} from "@openzeppelin/contracts/token/ERC20/extensions/ERC4626.sol";
import {IERC20Permit} from "@openzeppelin/contracts/token/ERC20/extensions/IERC20Permit.sol";
import {SafeERC20} from "@openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol";
import {Math} from "@openzeppelin/contracts/utils/math/Math.sol";
import {SafeCast} from "@openzeppelin/contracts/utils/math/SafeCast.sol";
Expand Down
16 changes: 5 additions & 11 deletions protocol-contracts/staking/test/OperatorStaking.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,37 +157,31 @@ describe('OperatorStaking', function () {
const sig = ethers.Signature.from(flatSig);

// Deposit with permit
const depositWithPermitTx = await this.mock
const depositWithPermitTx = this.mock
.connect(delegatorNoApproval)
.depositWithPermit(value, delegatorNoApproval, deadline, sig.v, sig.r, sig.s);

const depositWithPermitReceipt = await depositWithPermitTx.wait();

if (depositWithPermitReceipt?.status !== 1) {
throw new Error('Deposit with permit failed');
}

Object.assign(this, {
depositWithPermitReceipt: depositWithPermitReceipt,
depositWithPermitTx,
permitValue: value,
delegatorNoApproval: delegatorNoApproval,
});
});

it('should stake into protocol staking with permit', async function () {
expect(this.depositWithPermitReceipt)
await expect(this.depositWithPermitTx)
.to.emit(this.token, 'Transfer')
.withArgs(this.mock, this.protocolStaking, this.permitValue);
});

it('should mint shares with permit', async function () {
expect(this.depositWithPermitReceipt)
await expect(this.depositWithPermitTx)
.to.emit(this.mock, 'Transfer')
.withArgs(ethers.ZeroAddress, this.delegatorNoApproval, this.permitValue);
});

it('should pull tokens with permit', async function () {
expect(this.depositWithPermitReceipt)
await expect(this.depositWithPermitTx)
.to.emit(this.token, 'Transfer')
.withArgs(this.delegatorNoApproval, this.mock, this.permitValue);
});
Expand Down
Loading