Skip to content

docs(common): remove deprecated DecryptionOracle references#1597

Merged
mergify[bot] merged 2 commits intomainfrom
docs/remove-decryption-oracle
Dec 22, 2025
Merged

docs(common): remove deprecated DecryptionOracle references#1597
mergify[bot] merged 2 commits intomainfrom
docs/remove-decryption-oracle

Conversation

@enitrat
Copy link
Copy Markdown
Contributor

@enitrat enitrat commented Dec 17, 2025

  • Remove Oracle references from sdk-guides (public-decryption.md, sdk-overview.md)
  • Remove Oracle references from solidity-guides/configure.md
  • Replace deprecated DecryptionOracle section in coprocessor docs with current Public Decryption flow

There are still references to the old Decryption oracle pattern that I did not address as those were not publicly accessible pages

@enitrat enitrat requested review from a team as code owners December 17, 2025 14:17
@cla-bot cla-bot bot added the cla-signed label Dec 17, 2025
@mergify
Copy link
Copy Markdown

mergify bot commented Dec 17, 2025

🧪 CI Insights

Here's what we observed from your CI run for ecc00af.

🟢 All jobs passed!

But CI Insights is watching 👀

Copy link
Copy Markdown
Contributor

@melanciani melanciani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks ! a few comments to update though

@melanciani melanciani requested a review from 0xalexbel December 17, 2025 17:11
@enitrat
Copy link
Copy Markdown
Contributor Author

enitrat commented Dec 17, 2025

Regarding the KMSVerifier section comment: this is out of scope for this PR. Created https://github.com/zama-ai/fhevm-internal/issues/797 to track fixing this.

@enitrat enitrat changed the title docs: remove deprecated DecryptionOracle references docs(common): remove deprecated DecryptionOracle references Dec 17, 2025
@enitrat enitrat requested a review from melanciani December 17, 2025 20:28
Copy link
Copy Markdown
Contributor

@melanciani melanciani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@enitrat
Copy link
Copy Markdown
Contributor Author

enitrat commented Dec 18, 2025

@Mergifyio queue

@mergify
Copy link
Copy Markdown

mergify bot commented Dec 18, 2025

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at 0e87219

@mergify
Copy link
Copy Markdown

mergify bot commented Dec 18, 2025

Merge Queue Status

✅ The pull request has been merged at ecc00af

This pull request spent 13 minutes 54 seconds in the queue, including 12 minutes 40 seconds running CI.
The checks were run on draft #1632.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
  • check-success = run-e2e-tests / fhevm-e2e-test
  • any of [🛡 GitHub branch protection]:
    • check-success = common-pull-request/lint (bpr)
    • check-neutral = common-pull-request/lint (bpr)
    • check-skipped = common-pull-request/lint (bpr)
  • any of [🛡 GitHub branch protection]:
    • check-skipped = coprocessor-cargo-listener-tests/cargo-tests (bpr)
    • check-neutral = coprocessor-cargo-listener-tests/cargo-tests (bpr)
    • check-success = coprocessor-cargo-listener-tests/cargo-tests (bpr)
  • any of [🛡 GitHub branch protection]:
    • check-skipped = coprocessor-cargo-test/cargo-tests (bpr)
    • check-neutral = coprocessor-cargo-test/cargo-tests (bpr)
    • check-success = coprocessor-cargo-test/cargo-tests (bpr)
  • any of [🛡 GitHub branch protection]:
    • check-skipped = coprocessor-dependency-analysis/dependencies-check (bpr)
    • check-neutral = coprocessor-dependency-analysis/dependencies-check (bpr)
    • check-success = coprocessor-dependency-analysis/dependencies-check (bpr)
  • any of [🛡 GitHub branch protection]:
    • check-skipped = gateway-contracts-deployment-tests/sc-deploy (bpr)
    • check-neutral = gateway-contracts-deployment-tests/sc-deploy (bpr)
    • check-success = gateway-contracts-deployment-tests/sc-deploy (bpr)
  • any of [🛡 GitHub branch protection]:
    • check-skipped = kms-connector-tests/test-connector (bpr)
    • check-neutral = kms-connector-tests/test-connector (bpr)
    • check-success = kms-connector-tests/test-connector (bpr)

Copy link
Copy Markdown
Contributor

@0xalexbel 0xalexbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…elf-relaying pattern

  - Remove Oracle references from sdk-guides (public-decryption.md, sdk-overview.md, initialization.md)
  - Remove Oracle references from solidity-guides/configure.md
  - Replace deprecated DecryptionOracle section in coprocessor docs with current Public Decryption flow
@enitrat enitrat force-pushed the docs/remove-decryption-oracle branch from 2e3b6c7 to ecc00af Compare December 22, 2025 10:30
mergify bot added a commit that referenced this pull request Dec 22, 2025
mergify bot added a commit that referenced this pull request Dec 22, 2025
@mergify mergify bot merged commit 0e87219 into main Dec 22, 2025
69 checks passed
@mergify mergify bot deleted the docs/remove-decryption-oracle branch December 22, 2025 11:15
@mergify mergify bot removed the queued label Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants