fix(host-contracts): rename KMSVerifier test functions to match actual function#1604
Merged
fix(host-contracts): rename KMSVerifier test functions to match actual function#1604
Conversation
…l function Rename test functions from `test_VerifyInputEIP712KMSSignatures*` to `test_VerifyDecryptionEIP712KMSSignatures*` to accurately reflect the actual function being tested (`verifyDecryptionEIP712KMSSignatures`). Also update NatSpec comments that incorrectly referenced the old name.
enitrat
force-pushed
the
fix/kmsverifier-test-names
branch
from
778690d to
ee930f4
Compare
🧪 CI InsightsHere's what we observed from your CI run for ee930f4. 🟢 All jobs passed!But CI Insights is watching 👀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_VerifyInputEIP712KMSSignatures*totest_VerifyDecryptionEIP712KMSSignatures*Context
The KMSVerifier test file contains several test functions that are named
test_VerifyInputEIP712KMSSignatures*but they actually test theverifyDecryptionEIP712KMSSignaturesfunction. This naming inconsistency is confusing and doesn't accurately describe what the tests are verifying.The tests verify decryption signature verification, not input verification (which is handled by the separate InputVerifier contract).
Renamed tests:
test_VerifyInputEIP712KMSSignaturesWork→test_VerifyDecryptionEIP712KMSSignaturesWorktest_VerifyInputEIP712KMSSignaturesFailAsExpectedIfDigestIsInvalid→test_VerifyDecryptionEIP712KMSSignaturesFailAsExpectedIfDigestIsInvalidtest_VerifyInputEIP712KMSSignaturesFailAsExpectedIfNoSignerAdded→test_VerifyDecryptionEIP712KMSSignaturesFailAsExpectedIfNoSignerAddedtest_VerifyInputEIP712KMSSignaturesFailAsExpectedIfNoSignatureProvided→test_VerifyDecryptionEIP712KMSSignaturesFailAsExpectedIfNoSignatureProvidedtest_VerifyInputEIP712KMSSignaturesFailAsExpectedIfNumberOfSignaturesIsInferiorToThreshold→test_VerifyDecryptionEIP712KMSSignaturesFailAsExpectedIfNumberOfSignaturesIsInferiorToThresholdtest_VerifyInputEIP712KMSSignaturesFailAsExpectedIfSameSignerIsUsedTwice→test_VerifyDecryptionEIP712KMSSignaturesFailAsExpectedIfSameSignerIsUsedTwicetest_VerifyInputEIP712KMSSignaturesFailsIfEmptyDecryptionProof→test_VerifyDecryptionEIP712KMSSignaturesFailsIfEmptyDecryptionProoftest_VerifyInputEIP712KMSSignaturesFailsIfDeserializingDecryptionProofFail→test_VerifyDecryptionEIP712KMSSignaturesFailsIfDeserializingDecryptionProofFailTest plan