fix(protocol-contracts): skip zero-amount stake/unstake operations (N-08)

[melanciani]

NOTE: as opposed to the audit report, I introduced a revert in unstake instead of an early return like in stake because it is unclear what releaseTime we should consider then. We'll first need to confirm this with auditors

• Add early return for zero-amount stake in ProtocolStaking
• Add revert with ZeroUnstakeAmount error for zero-amount unstake in ProtocolStaking
• Add revert with NoAssetsToWithdraw error in OperatorStaking.requestRedeem when no assets to withdraw
• Add tests for new behaviors

refs https://github.com/zama-ai/fhevm-internal/issues/826

[mergify]

🧪 CI Insights

Here's what we observed from your CI run for b8d5b24.

🟢 All jobs passed!

But CI Insights is watching 👀

[arr00]

This introduces a bug, and I recommend against taking this approach.

fhevm/protocol-contracts/staking/contracts/OperatorStaking.sol

Line 197 in b8d5b24

require(assetsToWithdraw > 0, NoAssetsToWithdraw());

The line linked above makes it so that if there are excess funds in the OperatorStaking contract over the requested redemption, they must be restaked via stakeExcess.

[melanciani]

we believe that addressing the issue does more harm than good, let's close the PR