fix(coprocessor): do not update is_completed on unallowed handles#1695
Closed
antoniupop wants to merge 1 commit intorelease/0.10.xfrom
Closed
fix(coprocessor): do not update is_completed on unallowed handles#1695antoniupop wants to merge 1 commit intorelease/0.10.xfrom
antoniupop wants to merge 1 commit intorelease/0.10.xfrom
Conversation
🧪 CI InsightsHere's what we observed from your CI run for c1421d9. 🟢 All jobs passed!But CI Insights is watching 👀 |
deasydoesit
previously approved these changes
Dec 30, 2025
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where the is_completed flag was being incorrectly set for unallowed computation handles. The fix ensures that only successfully computed handles (which are allowed) have their is_completed status updated, and sets is_completed = true immediately for unallowed computations when they are inserted into the database.
Key changes:
- Modified handle tracking logic to only mark successfully computed handles as complete
- Added
is_completedcolumn to the computation insertion SQL with logic to set it based onis_allowedstatus - Wrapped database operations in conditional blocks to avoid unnecessary queries when there's no data to process
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| coprocessor/fhevm-engine/tfhe-worker/src/tfhe_worker.rs | Changed handles_to_update initialization from including intermediate and unneeded handles to only including successfully computed results; added conditional guards around database operations |
| coprocessor/fhevm-engine/host-listener/src/database/tfhe_event_propagate.rs | Added is_completed column to computation INSERT statement, setting it to !log.is_allowed to immediately mark unallowed computations as complete |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
coprocessor/fhevm-engine/host-listener/src/database/tfhe_event_propagate.rs
Show resolved
Hide resolved
9113537 to
2671d3b
Compare
rudy-6-4
previously approved these changes
Dec 30, 2025
2671d3b to
2373b73
Compare
rudy-6-4
previously approved these changes
Dec 30, 2025
2373b73 to
c1421d9
Compare
rudy-6-4
approved these changes
Jan 2, 2026
Collaborator
Author
|
No longer relevant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.