fix(protocol-contracts): round up unpaid fee to prevent extra reward distribution#1701
Closed
melanciani wants to merge 1 commit intomainfrom
Closed
Conversation
🧪 CI InsightsHere's what we observed from your CI run for 4b9ee62. 🟢 All jobs passed!But CI Insights is watching 👀 |
melanciani
force-pushed
the
melanciani/fix/protocol-contracts/staking/round_up_fee_in_historical_reward
branch
from
35682c3 to
4b9ee62
Compare
jatZama
reviewed
Jan 3, 2026
| // delegator allocations would be slightly higher than expected as it is based on total | ||
| // accumulated rewards subtracted by this unpaid fee amount, reversing the rounding direction. | ||
| // This could prevent the last depositor (or the beneficiary) from claiming their rewards. | ||
| return totalAssetsPlusPaidRewardsDelta.mulDiv(feeBasisPoints(), 10_000, Math.Rounding.Ceil); |
Member
There was a problem hiding this comment.
This is not what OZ suggested for the fix. You should keep original rounding down behaviour, because this is the correct behaviour for the _claimFee function.
On the other hand, you should create a new function variant called _unpaidFeeRoundUp or _unpaidFeeCeil for eg, which contain this formula with the rounding up, and which would be used to compute the historicalReward.
Contributor
Author
|
issue has been closed as false positive, closing this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs https://github.com/zama-ai/fhevm-internal/issues/826