Skip to content

refactor(gateway-contracts): improve pause all contracts method behavior#1747

Open
isaacdecoded wants to merge 6 commits intomainfrom
isaac/833/refactor/improve-pause-all-contracts-method-behavior
Open

refactor(gateway-contracts): improve pause all contracts method behavior#1747
isaacdecoded wants to merge 6 commits intomainfrom
isaac/833/refactor/improve-pause-all-contracts-method-behavior

Conversation

@isaacdecoded
Copy link
Contributor

@cla-bot cla-bot bot added the cla-signed label Jan 8, 2026
@isaacdecoded isaacdecoded marked this pull request as ready for review January 8, 2026 10:40
@isaacdecoded isaacdecoded requested a review from a team as a code owner January 8, 2026 10:40
@isaacdecoded isaacdecoded requested a review from jatZama January 8, 2026 10:40
@mergify
Copy link

mergify bot commented Jan 8, 2026

🧪 CI Insights

Here's what we observed from your CI run for 5d79fb1.

🟢 All jobs passed!

But CI Insights is watching 👀

Copy link
Member

@jatZama jatZama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic is sound, great work.
I think you should bump the version (MINOR_VERSION and REINITIALIZER_VERSION) of GatewayConfig contract, wdyt? Or is the version bumping done only right before deployment the upgraded version? I don't remember.

@isaacdecoded isaacdecoded requested a review from a team as a code owner January 8, 2026 11:11
@isaacdecoded
Copy link
Contributor Author

The logic is sound, great work. I think you should bump the version (MINOR_VERSION and REINITIALIZER_VERSION) of GatewayConfig contract, wdyt? Or is the version bumping done only right before deployment the upgraded version? I don't remember.

@jatZama, versions bumped here. Also enabled the upgrade tests CI. Thanks for the catch! ✊

@isaacdecoded isaacdecoded requested a review from jatZama January 8, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants